dmaengine: ste_dma40: Fix PM disable depth imbalance in d40_probe

ZhangShurong · vinodkoul · commit 0618c077a8c2 · 2023-10-09T10:56:51.000+05:30
The pm_runtime_enable will increase power disable depth. Thus a pairing decrement is needed on the error handling path to keep it balanced according to context. We fix it by calling pm_runtime_disable when error returns. Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Link: https://lore.kernel.org/r/tencent_DD2D371DB5925B4B602B1E1D0A5FA88F1208@qq.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
@@ -3668,6 +3668,7 @@ static int __init d40_probe(struct platform_device *pdev)
 		regulator_disable(base->lcpa_regulator);
 		regulator_put(base->lcpa_regulator);
 	}
+	pm_runtime_disable(base->dev);
 
  report_failure:
 	d40_err(dev, "probe failed\n");

Original file line number	Diff line number	Diff line change
`@@ -3668,6 +3668,7 @@ static int __init d40_probe(struct platform_device *pdev)`
`3668`	`3668`	`regulator_disable(base->lcpa_regulator);`
`3669`	`3669`	`regulator_put(base->lcpa_regulator);`
`3670`	`3670`	`}`
	`3671`	`+ pm_runtime_disable(base->dev);`
`3671`	`3672`
`3672`	`3673`	`report_failure:`
`3673`	`3674`	`d40_err(dev, "probe failed\n");`