Skip to content

Commit 063452f

Browse files
yangzhonKAGA-KOKO
authored andcommitted
x86/fpu/xstate: Fix the ARCH_REQ_XCOMP_PERM implementation
ARCH_REQ_XCOMP_PERM is supposed to add the requested feature to the permission bitmap of thread_group_leader()->fpu. But the code overwrites the bitmap with the requested feature bit only rather than adding it. Fix the code to add the requested feature bit to the master bitmask. Fixes: db8268d ("x86/arch_prctl: Add controls for dynamic XSTATE components") Signed-off-by: Yang Zhong <yang.zhong@intel.com> Signed-off-by: Chang S. Bae <chang.seok.bae@intel.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Paolo Bonzini <bonzini@gnu.org> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20220129173647.27981-2-chang.seok.bae@intel.com
1 parent 6b1f86f commit 063452f

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

arch/x86/kernel/fpu/xstate.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1639,7 +1639,7 @@ static int __xstate_request_perm(u64 permitted, u64 requested, bool guest)
16391639

16401640
perm = guest ? &fpu->guest_perm : &fpu->perm;
16411641
/* Pairs with the READ_ONCE() in xstate_get_group_perm() */
1642-
WRITE_ONCE(perm->__state_perm, requested);
1642+
WRITE_ONCE(perm->__state_perm, mask);
16431643
/* Protected by sighand lock */
16441644
perm->__state_size = ksize;
16451645
perm->__user_state_size = usize;

0 commit comments

Comments
 (0)