Skip to content

Commit 0638c98

Browse files
Vannoonnooalexdeucher
authored andcommitted
drm/amd/pm: Prevent divide by zero
divide error: 0000 [#1] SMP PTI CPU: 3 PID: 78925 Comm: tee Not tainted 5.15.50-1-lts #1 Hardware name: MSI MS-7A59/Z270 SLI PLUS (MS-7A59), BIOS 1.90 01/30/2018 RIP: 0010:smu_v11_0_set_fan_speed_rpm+0x11/0x110 [amdgpu] Speed is user-configurable through a file. I accidentally set it to zero, and the driver crashed. Reviewed-by: Evan Quan <evan.quan@amd.com> Reviewed-by: André Almeida <andrealmeid@igalia.com> Signed-off-by: Yefim Barashkin <mr.b34r@kolabnow.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> Cc: stable@vger.kernel.org
1 parent add61d3 commit 0638c98

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1228,6 +1228,8 @@ int smu_v11_0_set_fan_speed_rpm(struct smu_context *smu,
12281228
uint32_t crystal_clock_freq = 2500;
12291229
uint32_t tach_period;
12301230

1231+
if (speed == 0)
1232+
return -EINVAL;
12311233
/*
12321234
* To prevent from possible overheat, some ASICs may have requirement
12331235
* for minimum fan speed:

0 commit comments

Comments
 (0)