ethernet: aeroflex: fix potential skb leak in greth_init_rings()

Zhang Changzhong · Paolo Abeni · commit 063a932b64db · 2022-12-07T11:45:52.000+01:00
The greth_init_rings() function won't free the newly allocated skb when dma_mapping_error() returns error, so add dev_kfree_skb() to fix it. Compile tested only. Fixes: d4c4113 ("net: Add Aeroflex Gaisler 10/100/1G Ethernet MAC driver") Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com> Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Link: https://lore.kernel.org/r/1670134149-29516-1-git-send-email-zhangchangzhong@huawei.com Signed-off-by: Paolo Abeni <pabeni@redhat.com>
diff --git a/drivers/net/ethernet/aeroflex/greth.c b/drivers/net/ethernet/aeroflex/greth.c
@@ -258,6 +258,7 @@ static int greth_init_rings(struct greth_private *greth)
 			if (dma_mapping_error(greth->dev, dma_addr)) {
 				if (netif_msg_ifup(greth))
 					dev_err(greth->dev, "Could not create initial DMA mapping\n");
+				dev_kfree_skb(skb);
 				goto cleanup;
 			}
 			greth->rx_skbuff[i] = skb;

Original file line number	Diff line number	Diff line change
`@@ -258,6 +258,7 @@ static int greth_init_rings(struct greth_private *greth)`
`258`	`258`	`if (dma_mapping_error(greth->dev, dma_addr)) {`
`259`	`259`	`if (netif_msg_ifup(greth))`
`260`	`260`	`dev_err(greth->dev, "Could not create initial DMA mapping\n");`
	`261`	`+ dev_kfree_skb(skb);`
`261`	`262`	`goto cleanup;`
`262`	`263`	`}`
`263`	`264`	`greth->rx_skbuff[i] = skb;`