Skip to content

Commit 0653d50

Browse files
vsyrjalarodrigovivi
authored andcommitted
drm/i915: Disable port sync when bigjoiner is used
The current modeset sequence can't handle port sync and bigjoiner at the same time. Refuse port sync when bigjoiner is needed, at least until we fix the modeset sequence. v2: Add a FIXME (Vandite) Cc: stable@vger.kernel.org Tested-by: Vidya Srinivas <vidya.srinivas@intel.com> Reviewed-by: Vandita Kulkarni <vandita.kulkarni@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240404213441.17637-4-ville.syrjala@linux.intel.com Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> (cherry picked from commit b37e134) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent e3d4ead commit 0653d50

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

drivers/gpu/drm/i915/display/intel_ddi.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4256,7 +4256,12 @@ static bool m_n_equal(const struct intel_link_m_n *m_n_1,
42564256
static bool crtcs_port_sync_compatible(const struct intel_crtc_state *crtc_state1,
42574257
const struct intel_crtc_state *crtc_state2)
42584258
{
4259+
/*
4260+
* FIXME the modeset sequence is currently wrong and
4261+
* can't deal with bigjoiner + port sync at the same time.
4262+
*/
42594263
return crtc_state1->hw.active && crtc_state2->hw.active &&
4264+
!crtc_state1->bigjoiner_pipes && !crtc_state2->bigjoiner_pipes &&
42604265
crtc_state1->output_types == crtc_state2->output_types &&
42614266
crtc_state1->output_format == crtc_state2->output_format &&
42624267
crtc_state1->lane_count == crtc_state2->lane_count &&

0 commit comments

Comments
 (0)