scsi: hisi_sas: Check devm_add_action() return value

void0red · martinkpetersen · commit 06d1a90de602 · 2023-03-06T18:33:12.000-05:00
In case devm_add_action() fails, check it in the caller of interrupt_preinit_v3_hw(). Link: https://lore.kernel.org/r/20230227031030.893324-1-void0red@gmail.com Signed-off-by: Kang Chen <void0red@gmail.com> Acked-by: Xiang Chen <chenxiang66@hisilicon.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
@@ -2495,8 +2495,7 @@ static int interrupt_preinit_v3_hw(struct hisi_hba *hisi_hba)
 	hisi_hba->cq_nvecs = vectors - BASE_VECTORS_V3_HW;
 	shost->nr_hw_queues = hisi_hba->cq_nvecs;
 
-	devm_add_action(&pdev->dev, hisi_sas_v3_free_vectors, pdev);
-	return 0;
+	return devm_add_action(&pdev->dev, hisi_sas_v3_free_vectors, pdev);
 }
 
 static int interrupt_init_v3_hw(struct hisi_hba *hisi_hba)

Original file line number	Diff line number	Diff line change
`@@ -2495,8 +2495,7 @@ static int interrupt_preinit_v3_hw(struct hisi_hba *hisi_hba)`
`2495`	`2495`	`hisi_hba->cq_nvecs = vectors - BASE_VECTORS_V3_HW;`
`2496`	`2496`	`shost->nr_hw_queues = hisi_hba->cq_nvecs;`
`2497`	`2497`
`2498`		`- devm_add_action(&pdev->dev, hisi_sas_v3_free_vectors, pdev);`
`2499`		`- return 0;`
	`2498`	`+ return devm_add_action(&pdev->dev, hisi_sas_v3_free_vectors, pdev);`
`2500`	`2499`	`}`
`2501`	`2500`
`2502`	`2501`	`static int interrupt_init_v3_hw(struct hisi_hba *hisi_hba)`