ata: replace snprintf in show functions with sysfs_emit

Yang Guang · Damien Le Moal · commit 06d5d558f5a3 · 2021-12-02T13:13:45.000+09:00
coccinelle report：
./drivers/ata/libata-sata.c:830:8-16:
WARNING: use scnprintf or sprintf

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Reported-by: Zeal Robot &lt;zealci@zte.com.cn&gt;
Signed-off-by: Yang Guang &lt;yang.guang5@zte.com.cn&gt;
Signed-off-by: Damien Le Moal &lt;damien.lemoal@opensource.wdc.com&gt;
diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c
@@ -827,7 +827,7 @@ static ssize_t ata_scsi_lpm_show(struct device *dev,
 	if (ap->target_lpm_policy >= ARRAY_SIZE(ata_lpm_policy_names))
 		return -EINVAL;
 
-	return snprintf(buf, PAGE_SIZE, "%s\n",
+	return sysfs_emit(buf, "%s\n",
 			ata_lpm_policy_names[ap->target_lpm_policy]);
 }
 DEVICE_ATTR(link_power_management_policy, S_IRUGO | S_IWUSR,

Original file line number	Diff line number	Diff line change
`@@ -827,7 +827,7 @@ static ssize_t ata_scsi_lpm_show(struct device *dev,`
`827`	`827`	`if (ap->target_lpm_policy >= ARRAY_SIZE(ata_lpm_policy_names))`
`828`	`828`	`return -EINVAL;`
`829`	`829`
`830`		`- return snprintf(buf, PAGE_SIZE, "%s\n",`
	`830`	`+ return sysfs_emit(buf, "%s\n",`
`831`	`831`	`ata_lpm_policy_names[ap->target_lpm_policy]);`
`832`	`832`	`}`
`833`	`833`	`DEVICE_ATTR(link_power_management_policy, S_IRUGO \| S_IWUSR,`