Skip to content

Commit 07336df

Browse files
Uwe Kleine-Königmathieupoirier
authored andcommitted
remoteproc: qcom_wcnss: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org> Link: https://lore.kernel.org/r/20230504194453.1150368-14-u.kleine-koenig@pengutronix.de Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
1 parent 63c4e0d commit 07336df

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/remoteproc/qcom_wcnss.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -666,7 +666,7 @@ static int wcnss_probe(struct platform_device *pdev)
666666
return ret;
667667
}
668668

669-
static int wcnss_remove(struct platform_device *pdev)
669+
static void wcnss_remove(struct platform_device *pdev)
670670
{
671671
struct qcom_wcnss *wcnss = platform_get_drvdata(pdev);
672672

@@ -678,8 +678,6 @@ static int wcnss_remove(struct platform_device *pdev)
678678
qcom_remove_smd_subdev(wcnss->rproc, &wcnss->smd_subdev);
679679
wcnss_release_pds(wcnss);
680680
rproc_free(wcnss->rproc);
681-
682-
return 0;
683681
}
684682

685683
static const struct of_device_id wcnss_of_match[] = {
@@ -693,7 +691,7 @@ MODULE_DEVICE_TABLE(of, wcnss_of_match);
693691

694692
static struct platform_driver wcnss_driver = {
695693
.probe = wcnss_probe,
696-
.remove = wcnss_remove,
694+
.remove_new = wcnss_remove,
697695
.driver = {
698696
.name = "qcom-wcnss-pil",
699697
.of_match_table = wcnss_of_match,

0 commit comments

Comments
 (0)