Skip to content

Commit 074146f

Browse files
committed
drm/i915: Annotate more of the BIOS fb takeover failure paths
Annotate a few more of the failure paths on the initial BIOS fb takeover to avoid having to guess why things aren't working the way we expect. Reviewed-by: Uma Shankar <uma.shankar@intel.com> Tested-by: Paz Zcharya <pazz@chromium.org> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240202224340.30647-17-ville.syrjala@linux.intel.com
1 parent a815362 commit 074146f

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

drivers/gpu/drm/i915/display/intel_plane_initial.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,14 +167,19 @@ initial_plane_vma(struct drm_i915_private *i915,
167167
*/
168168
if (IS_ENABLED(CONFIG_FRAMEBUFFER_CONSOLE) &&
169169
mem == i915->mm.stolen_region &&
170-
size * 2 > i915->dsm.usable_size)
170+
size * 2 > i915->dsm.usable_size) {
171+
drm_dbg_kms(&i915->drm, "Initial FB size exceeds half of stolen, discarding\n");
171172
return NULL;
173+
}
172174

173175
obj = i915_gem_object_create_region_at(mem, phys_base, size,
174176
I915_BO_ALLOC_USER |
175177
I915_BO_PREALLOC);
176-
if (IS_ERR(obj))
178+
if (IS_ERR(obj)) {
179+
drm_dbg_kms(&i915->drm, "Failed to preallocate initial FB in %s\n",
180+
mem->region.name);
177181
return NULL;
182+
}
178183

179184
/*
180185
* Mark it WT ahead of time to avoid changing the

0 commit comments

Comments
 (0)