Skip to content

Commit 07b3af4

Browse files
nbd168kuba-moo
authored andcommitted
net: ethernet: mtk_eth_soc: fix tx throughput regression with direct 1G links
Using the QDMA tx scheduler to throttle tx to line speed works fine for switch ports, but apparently caused a regression on non-switch ports. Based on a number of tests, it seems that this throttling can be safely dropped without re-introducing the issues on switch ports that the tx scheduling changes resolved. Link: https://lore.kernel.org/netdev/trinity-92c3826f-c2c8-40af-8339-bc6d0d3ffea4-1678213958520@3c-app-gmx-bs16/ Fixes: f63959c ("net: ethernet: mtk_eth_soc: implement multi-queue support for per-port queues") Reported-by: Frank Wunderlich <frank-w@public-files.de> Reported-by: Daniel Golle <daniel@makrotopia.org> Tested-by: Daniel Golle <daniel@makrotopia.org> Signed-off-by: Felix Fietkau <nbd@nbd.name> Link: https://lore.kernel.org/r/20230324140404.95745-1-nbd@nbd.name Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 917fd7d commit 07b3af4

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

drivers/net/ethernet/mediatek/mtk_eth_soc.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -763,8 +763,6 @@ static void mtk_mac_link_up(struct phylink_config *config,
763763
break;
764764
}
765765

766-
mtk_set_queue_speed(mac->hw, mac->id, speed);
767-
768766
/* Configure duplex */
769767
if (duplex == DUPLEX_FULL)
770768
mcr |= MAC_MCR_FORCE_DPX;

0 commit comments

Comments
 (0)