Skip to content

Commit 07ed4f0

Browse files
bvanasschegroeck
authored andcommitted
hwmon: (it87) Check the it87_lock() return value
Return early in it87_resume() if it87_lock() fails instead of ignoring the return value of that function. This patch suppresses a Clang thread-safety warning. Cc: Frank Crawford <frank@crawford.emu.id.au> Cc: Guenter Roeck <linux@roeck-us.net> Cc: Jean Delvare <jdelvare@suse.com> Cc: linux-hwmon@vger.kernel.org Fixes: 376e1a9 ("hwmon: (it87) Add calls to smbus_enable/smbus_disable as required") Signed-off-by: Bart Van Assche <bvanassche@acm.org> Link: https://lore.kernel.org/r/20260223220102.2158611-15-bart.vanassche@linux.dev [groeck: Declare 'ret' at the beginning of it87_resume()] Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent e710b22 commit 07ed4f0

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

drivers/hwmon/it87.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3590,10 +3590,13 @@ static int it87_resume(struct device *dev)
35903590
{
35913591
struct platform_device *pdev = to_platform_device(dev);
35923592
struct it87_data *data = dev_get_drvdata(dev);
3593+
int err;
35933594

35943595
it87_resume_sio(pdev);
35953596

3596-
it87_lock(data);
3597+
err = it87_lock(data);
3598+
if (err)
3599+
return err;
35973600

35983601
it87_check_pwm(dev);
35993602
it87_check_limit_regs(data);

0 commit comments

Comments
 (0)