Skip to content

Commit 07fde75

Browse files
committed
perf kwork: Use zfree() to avoid possibly accessing dangling pointers
When freeing a->b it is good practice to set a->b to NULL using zfree(&a->b) so that when we have a bug where a reference to a freed 'a' pointer is kept somewhere, we can more quickly cause a segfault if some code tries to use a->b. Convert one such case in the 'perf kwork' codebase. Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Ian Rogers <irogers@google.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Kan Liang <kan.liang@linux.intel.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Yang Jihong <yangjihong1@huawei.com> Link: https://lore.kernel.org/lkml/Zjmc5EiN6zmWZj4r@x1 Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent 54ef362 commit 07fde75

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tools/perf/builtin-kwork.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2230,7 +2230,7 @@ static int perf_kwork__top(struct perf_kwork *kwork)
22302230
perf_kwork__top_report(kwork);
22312231

22322232
out:
2233-
free(kwork->top_stat.cpus_runtime);
2233+
zfree(&kwork->top_stat.cpus_runtime);
22342234
return ret;
22352235
}
22362236

0 commit comments

Comments
 (0)