Skip to content

Commit 081397d

Browse files
Lotte-BaiVasily Gorbik
authored andcommitted
s390/tape: use bitwise instead of arithmetic operator for flags
This silences the following coccinelle warning: drivers/s390/char/tape_34xx.c:360:38-39: WARNING: sum of probable bitmasks, consider | Signed-off-by: Haowen Bai <baihaowen@meizu.com> Link: https://lore.kernel.org/r/1647334421-29989-1-git-send-email-baihaowen@meizu.com Signed-off-by: Heiko Carstens <hca@linux.ibm.com> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
1 parent 6ffbeb3 commit 081397d

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/s390/char/tape_34xx.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -354,10 +354,10 @@ tape_34xx_unit_check(struct tape_device *device, struct tape_request *request,
354354
if ((
355355
sense[0] == SENSE_DATA_CHECK ||
356356
sense[0] == SENSE_EQUIPMENT_CHECK ||
357-
sense[0] == SENSE_EQUIPMENT_CHECK + SENSE_DEFERRED_UNIT_CHECK
357+
sense[0] == (SENSE_EQUIPMENT_CHECK | SENSE_DEFERRED_UNIT_CHECK)
358358
) && (
359359
sense[1] == SENSE_DRIVE_ONLINE ||
360-
sense[1] == SENSE_BEGINNING_OF_TAPE + SENSE_WRITE_MODE
360+
sense[1] == (SENSE_BEGINNING_OF_TAPE | SENSE_WRITE_MODE)
361361
)) {
362362
switch (request->op) {
363363
/*

0 commit comments

Comments
 (0)