Skip to content

Commit 08475da

Browse files
committed
kfence: use better stack hash seed
As of the prior commit, the RNG will have incorporated both a cycle counter value and RDRAND, in addition to various other environmental noise. Therefore, using get_random_u32() will supply a stronger seed than simply using random_get_entropy(). N.B.: random_get_entropy() should be considered an internal API of random.c and not generally consumed. Cc: Alexander Potapenko <glider@google.com> Cc: Dmitry Vyukov <dvyukov@google.com> Cc: Andrew Morton <akpm@linux-foundation.org> Reviewed-by: Marco Elver <elver@google.com> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
1 parent f623849 commit 08475da

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

mm/kfence/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -864,7 +864,7 @@ static void kfence_init_enable(void)
864864

865865
void __init kfence_init(void)
866866
{
867-
stack_hash_seed = (u32)random_get_entropy();
867+
stack_hash_seed = get_random_u32();
868868

869869
/* Setting kfence_sample_interval to 0 on boot disables KFENCE. */
870870
if (!kfence_sample_interval)

0 commit comments

Comments
 (0)