Skip to content

Commit 085d16d

Browse files
da-xTrond Myklebust
authored andcommitted
nfs: fix broken handling of the softreval mount option
Turns out that ever since this mount option was added, passing `softreval` in NFS mount options cancelled all other flags while not affecting the underlying flag `NFS_MOUNT_SOFTREVAL`. Fixes: c74dfe9 ("NFS: Add mount option 'softreval'") Signed-off-by: Dan Aloni <dan.aloni@vastdata.com> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
1 parent fd13359 commit 085d16d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/nfs/fs_context.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -517,7 +517,7 @@ static int nfs_fs_context_parse_param(struct fs_context *fc,
517517
if (result.negated)
518518
ctx->flags &= ~NFS_MOUNT_SOFTREVAL;
519519
else
520-
ctx->flags &= NFS_MOUNT_SOFTREVAL;
520+
ctx->flags |= NFS_MOUNT_SOFTREVAL;
521521
break;
522522
case Opt_posix:
523523
if (result.negated)

0 commit comments

Comments
 (0)