nvmet-tcp: do not continue for invalid icreq

hreinecke · keithbusch · commit 0889d13b9e1c · 2024-03-08T06:49:57.000-08:00
When the length check for an icreq sqe fails we should not
continue processing but rather return immediately as all
other contents of that sqe cannot be relied on.

Signed-off-by: Hannes Reinecke &lt;hare@suse.de&gt;
Reviewed-by: Christoph Hellwig &lt;hch@lst.de&gt;
Reviewed-by: Sagi Grimberg &lt;sagi@grimberg.me&gt;
Signed-off-by: Keith Busch &lt;kbusch@kernel.org&gt;
diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c
@@ -898,6 +898,7 @@ static int nvmet_tcp_handle_icreq(struct nvmet_tcp_queue *queue)
 		pr_err("bad nvme-tcp pdu length (%d)\n",
 			le32_to_cpu(icreq->hdr.plen));
 		nvmet_tcp_fatal_error(queue);
+		return -EPROTO;
 	}
 
 	if (icreq->pfv != NVME_TCP_PFV_1_0) {

Original file line number	Diff line number	Diff line change
`@@ -898,6 +898,7 @@ static int nvmet_tcp_handle_icreq(struct nvmet_tcp_queue *queue)`
`898`	`898`	`pr_err("bad nvme-tcp pdu length (%d)\n",`
`899`	`899`	`le32_to_cpu(icreq->hdr.plen));`
`900`	`900`	`nvmet_tcp_fatal_error(queue);`
	`901`	`+ return -EPROTO;`
`901`	`902`	`}`
`902`	`903`
`903`	`904`	`if (icreq->pfv != NVME_TCP_PFV_1_0) {`