Skip to content

Commit 0917310

Browse files
committed
cifs: missing null check for newinode pointer
in cifs_do_create we check if newinode is valid before referencing it but are missing the check in one place in fs/cifs/dir.c Addresses-Coverity: 1357292 ("Dereference after null check") Acked-by: Sachin Prabhu <sprabhu@redhat.com> Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent 4c4a525 commit 0917310

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

fs/cifs/dir.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -384,10 +384,11 @@ cifs_do_create(struct inode *inode, struct dentry *direntry, unsigned int xid,
384384
goto out_err;
385385
}
386386

387-
if (S_ISDIR(newinode->i_mode)) {
388-
rc = -EISDIR;
389-
goto out_err;
390-
}
387+
if (newinode)
388+
if (S_ISDIR(newinode->i_mode)) {
389+
rc = -EISDIR;
390+
goto out_err;
391+
}
391392

392393
d_drop(direntry);
393394
d_add(direntry, newinode);

0 commit comments

Comments
 (0)