NFS: Fix a potential NULL dereference in nfs_get_client()

Dan Carpenter · Trond Myklebust · commit 09226e8303be · 2021-06-03T10:14:42.000-04:00
None of the callers are expecting NULL returns from nfs_get_client() so this code will lead to an Oops. It's better to return an error pointer. I expect that this is dead code so hopefully no one is affected. Fixes: 31434f4 ("nfs: check hostname in nfs_get_client") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
diff --git a/fs/nfs/client.c b/fs/nfs/client.c
@@ -406,7 +406,7 @@ struct nfs_client *nfs_get_client(const struct nfs_client_initdata *cl_init)
 
 	if (cl_init->hostname == NULL) {
 		WARN_ON(1);
-		return NULL;
+		return ERR_PTR(-EINVAL);
 	}
 
 	/* see if the client already exists */

Original file line number	Diff line number	Diff line change
`@@ -406,7 +406,7 @@ struct nfs_client nfs_get_client(const struct nfs_client_initdata cl_init)`
`406`	`406`
`407`	`407`	`if (cl_init->hostname == NULL) {`
`408`	`408`	`WARN_ON(1);`
`409`		`- return NULL;`
	`409`	`+ return ERR_PTR(-EINVAL);`
`410`	`410`	`}`
`411`	`411`
`412`	`412`	`/* see if the client already exists */`