Skip to content

Commit 0928fc1

Browse files
committed
iommu/arm-smmu-qcom: Don't build debug features as a kernel module
The Qualcomm TBU debug support introduced by 414ecb0 ("iommu/arm-smmu-qcom-debug: Add support for TBUs") provides its own driver initialisation function, which breaks the link when the core SMMU driver is built as a module: ld.lld: error: duplicate symbol: init_module >>> defined at arm-smmu.c >>> drivers/iommu/arm/arm-smmu/arm-smmu.o:(init_module) >>> defined at arm-smmu-qcom-debug.c >>> drivers/iommu/arm/arm-smmu/arm-smmu-qcom-debug.o:(.init.text+0x4) Since we're late in the cycle, just make the debug features depend on a non-modular SMMU driver for now while the initialisation is reworked to hang off qcom_smmu_impl_init(). Signed-off-by: Will Deacon <will@kernel.org>
1 parent b8ca7ce commit 0928fc1

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/iommu/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ config ARM_SMMU_QCOM
376376

377377
config ARM_SMMU_QCOM_DEBUG
378378
bool "ARM SMMU QCOM implementation defined debug support"
379-
depends on ARM_SMMU_QCOM
379+
depends on ARM_SMMU_QCOM=y
380380
help
381381
Support for implementation specific debug features in ARM SMMU
382382
hardware found in QTI platforms. This include support for

0 commit comments

Comments
 (0)