nouveau/gsp/r535: uninitialized variable in r535_gsp_acpi_mux_id()

Dan Carpenter · dakr · commit 09f12bf9f790 · 2023-11-14T22:40:18.000+01:00
The if we hit the "continue" statement on the first iteration through the loop then "handle_mux" needs to be set to NULL so we continue looping. Fixes: 176fdcb ("drm/nouveau/gsp/r535: add support for booting GSP-RM") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Danilo Krummrich <dakr@redhat.com> Signed-off-by: Danilo Krummrich <dakr@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/1d864f6e-43e9-43d8-9d90-30e76c9c843b@moroto.mountain
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
@@ -1159,7 +1159,7 @@ static void
 r535_gsp_acpi_mux_id(acpi_handle handle, u32 id, MUX_METHOD_DATA_ELEMENT *mode,
 						 MUX_METHOD_DATA_ELEMENT *part)
 {
-	acpi_handle iter = NULL, handle_mux;
+	acpi_handle iter = NULL, handle_mux = NULL;
 	acpi_status status;
 	unsigned long long value;
 

Original file line number	Diff line number	Diff line change
`@@ -1159,7 +1159,7 @@ static void`
`1159`	`1159`	`r535_gsp_acpi_mux_id(acpi_handle handle, u32 id, MUX_METHOD_DATA_ELEMENT *mode,`
`1160`	`1160`	`MUX_METHOD_DATA_ELEMENT *part)`
`1161`	`1161`	`{`
`1162`		`- acpi_handle iter = NULL, handle_mux;`
	`1162`	`+ acpi_handle iter = NULL, handle_mux = NULL;`
`1163`	`1163`	`acpi_status status;`
`1164`	`1164`	`unsigned long long value;`
`1165`	`1165`