platform/x86: amd-pmc: only use callbacks for suspend

superm1 · jwrdegoede · commit 09fc14061f3e · 2021-12-21T19:35:27.000+01:00
This driver is intended to be used exclusively for suspend to idle so callbacks to send OS_HINT during hibernate and S5 will set OS_HINT at the wrong time leading to an undefined behavior. Cc: stable@vger.kernel.org Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Link: https://lore.kernel.org/r/20211210143529.10594-1-mario.limonciello@amd.com Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c
@@ -508,7 +508,8 @@ static int __maybe_unused amd_pmc_resume(struct device *dev)
 }
 
 static const struct dev_pm_ops amd_pmc_pm_ops = {
-	SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(amd_pmc_suspend, amd_pmc_resume)
+	.suspend_noirq = amd_pmc_suspend,
+	.resume_noirq = amd_pmc_resume,
 };
 
 static const struct pci_device_id pmc_pci_ids[] = {

Original file line number	Diff line number	Diff line change
`@@ -508,7 +508,8 @@ static int __maybe_unused amd_pmc_resume(struct device *dev)`
`508`	`508`	`}`
`509`	`509`
`510`	`510`	`static const struct dev_pm_ops amd_pmc_pm_ops = {`
`511`		`- SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(amd_pmc_suspend, amd_pmc_resume)`
	`511`	`+ .suspend_noirq = amd_pmc_suspend,`
	`512`	`+ .resume_noirq = amd_pmc_resume,`
`512`	`513`	`};`
`513`	`514`
`514`	`515`	`static const struct pci_device_id pmc_pci_ids[] = {`