Skip to content

Commit 0a924de

Browse files
ddmatsurleon
authored andcommitted
RDMA/rxe: Improve readability of ODP pagefault interface
Use a meaningful constant explicitly instead of hard-coding a literal. Signed-off-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com> Link: https://patch.msgid.link/20250312065937.1787241-1-matsuda-daisuke@fujitsu.com Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev> Signed-off-by: Leon Romanovsky <leon@kernel.org>
1 parent 8b6745b commit 0a924de

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

drivers/infiniband/sw/rxe/rxe_odp.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,9 @@ const struct mmu_interval_notifier_ops rxe_mn_ops = {
3737
.invalidate = rxe_ib_invalidate_range,
3838
};
3939

40-
#define RXE_PAGEFAULT_RDONLY BIT(1)
41-
#define RXE_PAGEFAULT_SNAPSHOT BIT(2)
40+
#define RXE_PAGEFAULT_DEFAULT 0
41+
#define RXE_PAGEFAULT_RDONLY BIT(0)
42+
#define RXE_PAGEFAULT_SNAPSHOT BIT(1)
4243
static int rxe_odp_do_pagefault_and_lock(struct rxe_mr *mr, u64 user_va, int bcnt, u32 flags)
4344
{
4445
struct ib_umem_odp *umem_odp = to_ib_umem_odp(mr->umem);
@@ -222,7 +223,7 @@ int rxe_odp_mr_copy(struct rxe_mr *mr, u64 iova, void *addr, int length,
222223
enum rxe_mr_copy_dir dir)
223224
{
224225
struct ib_umem_odp *umem_odp = to_ib_umem_odp(mr->umem);
225-
u32 flags = 0;
226+
u32 flags = RXE_PAGEFAULT_DEFAULT;
226227
int err;
227228

228229
if (length == 0)
@@ -236,7 +237,7 @@ int rxe_odp_mr_copy(struct rxe_mr *mr, u64 iova, void *addr, int length,
236237
break;
237238

238239
case RXE_FROM_MR_OBJ:
239-
flags = RXE_PAGEFAULT_RDONLY;
240+
flags |= RXE_PAGEFAULT_RDONLY;
240241
break;
241242

242243
default:
@@ -312,7 +313,8 @@ int rxe_odp_atomic_op(struct rxe_mr *mr, u64 iova, int opcode,
312313
struct ib_umem_odp *umem_odp = to_ib_umem_odp(mr->umem);
313314
int err;
314315

315-
err = rxe_odp_map_range_and_lock(mr, iova, sizeof(char), 0);
316+
err = rxe_odp_map_range_and_lock(mr, iova, sizeof(char),
317+
RXE_PAGEFAULT_DEFAULT);
316318
if (err < 0)
317319
return err;
318320

0 commit comments

Comments
 (0)