mtd: lpddr2_nvm: Warn about failure to unregister mtd device

Uwe Kleine-König · miquelraynal · commit 0aaa0b5f84a0 · 2022-06-09T15:06:16.000+02:00
mtd_device_unregister() shouldn't fail. Wail loudly if it does anyhow. This matches how other drivers (e.g. nand/raw/nandsim.c) use mtd_device_unregister(). By returning 0 in the platform remove callback a generic error message by the device core is suppressed, nothing else changes. This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20220603210758.148493-6-u.kleine-koenig@pengutronix.de
diff --git a/drivers/mtd/lpddr/lpddr2_nvm.c b/drivers/mtd/lpddr/lpddr2_nvm.c
@@ -478,7 +478,9 @@ static int lpddr2_nvm_probe(struct platform_device *pdev)
  */
 static int lpddr2_nvm_remove(struct platform_device *pdev)
 {
-	return mtd_device_unregister(dev_get_drvdata(&pdev->dev));
+	WARN_ON(mtd_device_unregister(dev_get_drvdata(&pdev->dev)));
+
+	return 0;
 }
 
 /* Initialize platform_driver data structure for lpddr2_nvm */

Original file line number	Diff line number	Diff line change
`@@ -478,7 +478,9 @@ static int lpddr2_nvm_probe(struct platform_device *pdev)`
`478`	`478`	`*/`
`479`	`479`	`static int lpddr2_nvm_remove(struct platform_device *pdev)`
`480`	`480`	`{`
`481`		`- return mtd_device_unregister(dev_get_drvdata(&pdev->dev));`
	`481`	`+ WARN_ON(mtd_device_unregister(dev_get_drvdata(&pdev->dev)));`
	`482`	`+`
	`483`	`+ return 0;`
`482`	`484`	`}`
`483`	`485`
`484`	`486`	`/* Initialize platform_driver data structure for lpddr2_nvm */`