drm/amdgpu: Do not program PF-only regs in hdp_v4_0.c under SRIOV (v2)

victorlu-amd · alexdeucher · commit 0b1695710ab8 · 2023-11-09T17:01:42.000-05:00
The following regs can only be programmed by the PF:
HDP_MISC_CNTL
HDP_NONSURFACE_BASE
HDP_NONSURFACE_BASE_HI

v2: update commit message

Signed-off-by: Victor Lu &lt;victorchengchi.lu@amd.com&gt;
Reviewed-by: Samir Dhume &lt;samir.dhume@amd.com&gt;
Signed-off-by: Alex Deucher &lt;alexander.deucher@amd.com&gt;
diff --git a/drivers/gpu/drm/amd/amdgpu/hdp_v4_0.c b/drivers/gpu/drm/amd/amdgpu/hdp_v4_0.c
@@ -145,6 +145,10 @@ static void hdp_v4_0_init_registers(struct amdgpu_device *adev)
 		break;
 	}
 
+	/* Do not program registers if VF */
+	if (amdgpu_sriov_vf(adev))
+		return;
+
 	WREG32_FIELD15(HDP, 0, HDP_MISC_CNTL, FLUSH_INVALIDATE_CACHE, 1);
 
 	if (amdgpu_ip_version(adev, HDP_HWIP, 0) == IP_VERSION(4, 4, 0))

Original file line number	Diff line number	Diff line change
`@@ -145,6 +145,10 @@ static void hdp_v4_0_init_registers(struct amdgpu_device *adev)`
`145`	`145`	`break;`
`146`	`146`	`}`
`147`	`147`
	`148`	`+ /* Do not program registers if VF */`
	`149`	`+ if (amdgpu_sriov_vf(adev))`
	`150`	`+ return;`
	`151`	`+`
`148`	`152`	`WREG32_FIELD15(HDP, 0, HDP_MISC_CNTL, FLUSH_INVALIDATE_CACHE, 1);`
`149`	`153`
`150`	`154`	`if (amdgpu_ip_version(adev, HDP_HWIP, 0) == IP_VERSION(4, 4, 0))`