Skip to content

Commit 0b39ce8

Browse files
Shyam Sundar S Kij-intel
authored andcommitted
platform/x86/amd/pmf: Use devm_mutex_init() for mutex initialization
Replace mutex_init() with the devm_mutex_init(), to ensure proper mutex cleanup during probe failure and driver removal. Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> Link: https://patch.msgid.link/20251119085813.546813-2-Shyam-sundar.S-k@amd.com Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
1 parent 2bd038d commit 0b39ce8

1 file changed

Lines changed: 11 additions & 6 deletions

File tree

  • drivers/platform/x86/amd/pmf

drivers/platform/x86/amd/pmf/core.c

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -465,9 +465,17 @@ static int amd_pmf_probe(struct platform_device *pdev)
465465
if (!dev->regbase)
466466
return -ENOMEM;
467467

468-
mutex_init(&dev->lock);
469-
mutex_init(&dev->update_mutex);
470-
mutex_init(&dev->cb_mutex);
468+
err = devm_mutex_init(dev->dev, &dev->lock);
469+
if (err)
470+
return err;
471+
472+
err = devm_mutex_init(dev->dev, &dev->update_mutex);
473+
if (err)
474+
return err;
475+
476+
err = devm_mutex_init(dev->dev, &dev->cb_mutex);
477+
if (err)
478+
return err;
471479

472480
apmf_acpi_init(dev);
473481
platform_set_drvdata(pdev, dev);
@@ -491,9 +499,6 @@ static void amd_pmf_remove(struct platform_device *pdev)
491499
amd_pmf_notify_sbios_heartbeat_event_v2(dev, ON_UNLOAD);
492500
apmf_acpi_deinit(dev);
493501
amd_pmf_dbgfs_unregister(dev);
494-
mutex_destroy(&dev->lock);
495-
mutex_destroy(&dev->update_mutex);
496-
mutex_destroy(&dev->cb_mutex);
497502
}
498503

499504
static const struct attribute_group *amd_pmf_driver_groups[] = {

0 commit comments

Comments
 (0)