Skip to content

Commit 0b57e2e

Browse files
Kate Hsuanjwrdegoede
authored andcommitted
platform/x86: x86-android-tablets: Xiaomi pad2 RGB LED fwnode updates
Xiaomi pad2 RGB LED fwnode updates: 1. Set "label" instead "function" to change the LED classdev name from "rgb:indicator" to "mipad2:rgb:indicator" to match the usual triplet name format for LED classdevs. 2. Set the trigger to the new "bq27520-0-charging-orange-full-green" powersupply trigger type for multi-color LEDs. 3. Put the fwnode link for red before green in ktd2026_node_group[] so that multi_index becomes "red green blue". Signed-off-by: Kate Hsuan <hpa@redhat.com> Reviewed-by: Andy Shevchenko <andy@kernel.org> Co-developed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20240504164105.114017-8-hdegoede@redhat.com
1 parent 492b119 commit 0b57e2e

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

  • drivers/platform/x86/x86-android-tablets

drivers/platform/x86/x86-android-tablets/other.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -609,8 +609,8 @@ static const struct software_node ktd2026_node = {
609609
static const struct property_entry ktd2026_rgb_led_props[] = {
610610
PROPERTY_ENTRY_U32("reg", 0),
611611
PROPERTY_ENTRY_U32("color", LED_COLOR_ID_RGB),
612-
PROPERTY_ENTRY_STRING("function", "indicator"),
613-
PROPERTY_ENTRY_STRING("linux,default-trigger", "bq27520-0-charging"),
612+
PROPERTY_ENTRY_STRING("label", "mipad2:rgb:indicator"),
613+
PROPERTY_ENTRY_STRING("linux,default-trigger", "bq27520-0-charging-orange-full-green"),
614614
{ }
615615
};
616616

@@ -656,9 +656,9 @@ static const struct software_node ktd2026_red_led_node = {
656656
static const struct software_node *ktd2026_node_group[] = {
657657
&ktd2026_node,
658658
&ktd2026_rgb_led_node,
659+
&ktd2026_red_led_node,
659660
&ktd2026_green_led_node,
660661
&ktd2026_blue_led_node,
661-
&ktd2026_red_led_node,
662662
NULL
663663
};
664664

0 commit comments

Comments
 (0)