Skip to content

Commit 0b64150

Browse files
krzkdtor
authored andcommitted
Input: bcm-keypad - correct dev_err_probe() error
Pass proper PTR_ERR as dev_err_probe() argument. Fixes: a2c795b ("Input: bcm-keypad - simplify with dev_err_probe()") Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/r/202306261505.wTjCXRIO-lkp@intel.com/ Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20230711072449.43569-1-krzysztof.kozlowski@linaro.org Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent f1efdf7 commit 0b64150

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/input/keyboard/bcm-keypad.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,7 @@ static int bcm_kp_probe(struct platform_device *pdev)
359359
/* Enable clock */
360360
kp->clk = devm_clk_get_optional(&pdev->dev, "peri_clk");
361361
if (IS_ERR(kp->clk)) {
362-
return dev_err_probe(&pdev->dev, error, "Failed to get clock\n");
362+
return dev_err_probe(&pdev->dev, PTR_ERR(kp->clk), "Failed to get clock\n");
363363
} else if (!kp->clk) {
364364
dev_dbg(&pdev->dev, "No clock specified. Assuming it's enabled\n");
365365
} else {

0 commit comments

Comments
 (0)