HID: pidff: Clamp effect playback LOOP_COUNT value

Lawstorant · Jiri Kosina · commit 0c6673e3d17b · 2025-03-04T21:42:44.000+01:00
Ensures the loop count will never exceed the logical_maximum.

Fixes implementation errors happening when applications use the max
value of int32/DWORD as the effect iterations. This could be observed
when running software both native and in wine.

Signed-off-by: Tomasz Pakuła &lt;tomasz.pakula.oficjalny@gmail.com&gt;
Signed-off-by: Jiri Kosina &lt;jkosina@suse.com&gt;
diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c
@@ -690,7 +690,8 @@ static void pidff_playback_pid(struct pidff_device *pidff, int pid_id, int n)
 	} else {
 		pidff->effect_operation_status->value[0] =
 			pidff->operation_id[PID_EFFECT_START];
-		pidff->effect_operation[PID_LOOP_COUNT].value[0] = n;
+		pidff->effect_operation[PID_LOOP_COUNT].value[0] =
+			pidff_clamp(n, pidff->effect_operation[PID_LOOP_COUNT].field);
 	}
 
 	hid_hw_request(pidff->hid, pidff->reports[PID_EFFECT_OPERATION],

Original file line number	Diff line number	Diff line change
`@@ -690,7 +690,8 @@ static void pidff_playback_pid(struct pidff_device *pidff, int pid_id, int n)`
`690`	`690`	`} else {`
`691`	`691`	`pidff->effect_operation_status->value[0] =`
`692`	`692`	`pidff->operation_id[PID_EFFECT_START];`
`693`		`- pidff->effect_operation[PID_LOOP_COUNT].value[0] = n;`
	`693`	`+ pidff->effect_operation[PID_LOOP_COUNT].value[0] =`
	`694`	`+ pidff_clamp(n, pidff->effect_operation[PID_LOOP_COUNT].field);`
`694`	`695`	`}`
`695`	`696`
`696`	`697`	`hid_hw_request(pidff->hid, pidff->reports[PID_EFFECT_OPERATION],`