Skip to content

Commit 0cb19e5

Browse files
author
Ulf Hansson
committed
pmdomain: arm: Avoid polling for scmi_perf_domain
It was a mistake to prefer polling based mode when setting a performance level for a domain. Let's instead rely on the protocol to decide what is best and thus avoid polling when possible. Reported-by: Nikunj Kela <nkela@quicinc.com> Fixes: 2af23ce ("pmdomain: arm: Add the SCMI performance domain") Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com> Link: https://lore.kernel.org/r/20231127135033.136442-1-ulf.hansson@linaro.org
1 parent 98b1cc8 commit 0cb19e5

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/pmdomain/arm/scmi_perf_domain.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ scmi_pd_set_perf_state(struct generic_pm_domain *genpd, unsigned int state)
3535
if (!state)
3636
return -EINVAL;
3737

38-
ret = pd->perf_ops->level_set(pd->ph, pd->domain_id, state, true);
38+
ret = pd->perf_ops->level_set(pd->ph, pd->domain_id, state, false);
3939
if (ret)
4040
dev_warn(&genpd->dev, "Failed with %d when trying to set %d perf level",
4141
ret, state);

0 commit comments

Comments
 (0)