Skip to content

Commit 0cc1325

Browse files
Mani-Sadhasivambjorn-helgaas
authored andcommitted
PCI: qcom: Remove ASPM L0s support for MSM8996 SoC
Though I couldn't confirm ASPM L0s support with the Qcom hardware team, a bug report from Dmitry suggests that L0s is broken on this legacy SoC. Hence, remove L0s support from the Root Port Link Capabilities in this SoC. Since qcom_pcie_clear_aspm_l0s() is now used by more than one SoC config, call it from qcom_pcie_host_init() instead. Reported-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Closes: https://lore.kernel.org/linux-pci/4cp5pzmlkkht2ni7us6p3edidnk25l45xrp6w3fxguqcvhq2id@wjqqrdpkypkf Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com> Signed-off-by: Manivannan Sadhasivam <mani@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Tested-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Link: https://patch.msgid.link/20251126081718.8239-1-mani@kernel.org
1 parent 8f0b4cc commit 0cc1325

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/pci/controller/dwc/pcie-qcom.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1047,7 +1047,6 @@ static int qcom_pcie_post_init_2_7_0(struct qcom_pcie *pcie)
10471047
writel(WR_NO_SNOOP_OVERRIDE_EN | RD_NO_SNOOP_OVERRIDE_EN,
10481048
pcie->parf + PARF_NO_SNOOP_OVERRIDE);
10491049

1050-
qcom_pcie_clear_aspm_l0s(pcie->pci);
10511050
qcom_pcie_clear_hpc(pcie->pci);
10521051

10531052
return 0;
@@ -1316,6 +1315,8 @@ static int qcom_pcie_host_init(struct dw_pcie_rp *pp)
13161315
goto err_disable_phy;
13171316
}
13181317

1318+
qcom_pcie_clear_aspm_l0s(pcie->pci);
1319+
13191320
qcom_ep_reset_deassert(pcie);
13201321

13211322
if (pcie->cfg->ops->config_sid) {
@@ -1464,6 +1465,7 @@ static const struct qcom_pcie_cfg cfg_2_1_0 = {
14641465

14651466
static const struct qcom_pcie_cfg cfg_2_3_2 = {
14661467
.ops = &ops_2_3_2,
1468+
.no_l0s = true,
14671469
};
14681470

14691471
static const struct qcom_pcie_cfg cfg_2_3_3 = {

0 commit comments

Comments
 (0)