Skip to content

Commit 0d195d3

Browse files
chrboeaxboe
authored andcommitted
drbd: fix null-pointer dereference on local read error
In drbd_request_endio(), READ_COMPLETED_WITH_ERROR is passed to __req_mod() with a NULL peer_device: __req_mod(req, what, NULL, &m); The READ_COMPLETED_WITH_ERROR handler then unconditionally passes this NULL peer_device to drbd_set_out_of_sync(), which dereferences it, causing a null-pointer dereference. Fix this by obtaining the peer_device via first_peer_device(device), matching how drbd_req_destroy() handles the same situation. Cc: stable@vger.kernel.org Reported-by: Tuo Li <islituo@gmail.com> Link: https://lore.kernel.org/linux-block/20260104165355.151864-1-islituo@gmail.com Signed-off-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 81b1f04 commit 0d195d3

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/block/drbd/drbd_req.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -621,7 +621,8 @@ int __req_mod(struct drbd_request *req, enum drbd_req_event what,
621621
break;
622622

623623
case READ_COMPLETED_WITH_ERROR:
624-
drbd_set_out_of_sync(peer_device, req->i.sector, req->i.size);
624+
drbd_set_out_of_sync(first_peer_device(device),
625+
req->i.sector, req->i.size);
625626
drbd_report_io_error(device, req);
626627
__drbd_chk_io_error(device, DRBD_READ_ERROR);
627628
fallthrough;

0 commit comments

Comments
 (0)