mtd: rawnand: loongson1: Fix error code in ls1x_nand_dma_transfer()

Dan Carpenter · miquelraynal · commit 0d470c72bea4 · 2025-05-12T16:28:15.000+02:00
The "desc" variable is NULL and PTR_ERR(NULL) is zero/success. Return a negative error code instead. Fixes: d2d10ed ("mtd: rawnand: Add Loongson-1 NAND Controller Driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
diff --git a/drivers/mtd/nand/raw/loongson1-nand-controller.c b/drivers/mtd/nand/raw/loongson1-nand-controller.c
@@ -371,7 +371,7 @@ static int ls1x_nand_dma_transfer(struct ls1x_nand_host *host, struct ls1x_nand_
 	desc = dmaengine_prep_slave_single(chan, dma_addr, op->len, xfer_dir, DMA_PREP_INTERRUPT);
 	if (!desc) {
 		dev_err(dev, "failed to prepare DMA descriptor\n");
-		ret = PTR_ERR(desc);
+		ret = -ENOMEM;
 		goto err;
 	}
 	desc->callback = ls1x_nand_dma_callback;

Original file line number	Diff line number	Diff line change
`@@ -371,7 +371,7 @@ static int ls1x_nand_dma_transfer(struct ls1x_nand_host *host, struct ls1x_nand_`
`371`	`371`	`desc = dmaengine_prep_slave_single(chan, dma_addr, op->len, xfer_dir, DMA_PREP_INTERRUPT);`
`372`	`372`	`if (!desc) {`
`373`	`373`	`dev_err(dev, "failed to prepare DMA descriptor\n");`
`374`		`- ret = PTR_ERR(desc);`
	`374`	`+ ret = -ENOMEM;`
`375`	`375`	`goto err;`
`376`	`376`	`}`
`377`	`377`	`desc->callback = ls1x_nand_dma_callback;`