memory: tegra: Skip SID programming if SID registers aren't set

ashishmhetre8 · krzk · commit 0d6c918011ce · 2023-11-21T10:09:28.000+01:00
There are few MC clients where SID security and override register offsets are not specified like "sw_cluster0" in tegra234. Don't program SID override for such clients because it leads to access to invalid addresses. Signed-off-by: Ashish Mhetre <amhetre@nvidia.com> Link: https://lore.kernel.org/r/20231107112713.21399-2-amhetre@nvidia.com Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
diff --git a/drivers/memory/tegra/tegra186.c b/drivers/memory/tegra/tegra186.c
@@ -75,6 +75,9 @@ static void tegra186_mc_client_sid_override(struct tegra_mc *mc,
 {
 	u32 value, old;
 
+	if (client->regs.sid.security == 0 && client->regs.sid.override == 0)
+		return;
+
 	value = readl(mc->regs + client->regs.sid.security);
 	if ((value & MC_SID_STREAMID_SECURITY_OVERRIDE) == 0) {
 		/*

Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,9 @@ static void tegra186_mc_client_sid_override(struct tegra_mc *mc,`
`75`	`75`	`{`
`76`	`76`	`u32 value, old;`
`77`	`77`
	`78`	`+ if (client->regs.sid.security == 0 && client->regs.sid.override == 0)`
	`79`	`+ return;`
	`80`	`+`
`78`	`81`	`value = readl(mc->regs + client->regs.sid.security);`
`79`	`82`	`if ((value & MC_SID_STREAMID_SECURITY_OVERRIDE) == 0) {`
`80`	`83`	`/*`