Skip to content

Commit 0d7dfc7

Browse files
lumagrobclark
authored andcommitted
drm/msm/a6xx: specify UBWC config for sc7180
Historically the Adreno driver has not been updating memory configuration registers on a618 (SC7180 platform) implying that the default configuration is fine. After the rework performed in the commit 8814455 ("drm/msm: Refactor UBWC config setting") the function a6xx_calc_ubwc_config() still contained this shortcut and did not calculate UBWC configuration. However the function which now actually updates hardware registers, a6xx_set_ubwc_config(), doesn't contain such check. Rather than adding the check to a6xx_set_ubwc_config(), fill in the UBWC config for a618 (based on readings from SC7180). Reported-by: Leonard Lausen <leonard@lausen.nl> Link: https://gitlab.freedesktop.org/drm/msm/-/issues/49 Fixes: 8814455 ("drm/msm: Refactor UBWC config setting") Cc: Connor Abbott <cwabbott0@gmail.com> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Connor Abbott <cwabbott0@gmail.com> Patchwork: https://patchwork.freedesktop.org/patch/579113/ Signed-off-by: Rob Clark <robdclark@chromium.org>
1 parent e3b1f36 commit 0d7dfc7

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/gpu/drm/msm/adreno/a6xx_gpu.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1292,9 +1292,8 @@ static void a6xx_calc_ubwc_config(struct adreno_gpu *gpu)
12921292
gpu->ubwc_config.ubwc_mode = 1;
12931293
}
12941294

1295-
/* a618 is using the hw default values */
12961295
if (adreno_is_a618(gpu))
1297-
return;
1296+
gpu->ubwc_config.highest_bank_bit = 14;
12981297

12991298
if (adreno_is_a619_holi(gpu))
13001299
gpu->ubwc_config.highest_bank_bit = 13;

0 commit comments

Comments
 (0)