Skip to content

Commit 0d82410

Browse files
stefano-garzarellamstsirkin
authored andcommitted
vdpa_sim_blk: allocate the buffer zeroed
Deleting and recreating a device can lead to having the same content as the old device, so let's always allocate buffers completely zeroed out. Fixes: abebb16 ("vdpa_sim_blk: support shared backend") Suggested-by: Qing Wang <qinwang@redhat.com> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> Message-Id: <20231031144339.121453-1-sgarzare@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Eugenio Pérez <eperezma@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com>
1 parent 3503895 commit 0d82410

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/vdpa/vdpa_sim/vdpa_sim_blk.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,7 @@ static int vdpasim_blk_dev_add(struct vdpa_mgmt_dev *mdev, const char *name,
437437
if (blk->shared_backend) {
438438
blk->buffer = shared_buffer;
439439
} else {
440-
blk->buffer = kvmalloc(VDPASIM_BLK_CAPACITY << SECTOR_SHIFT,
440+
blk->buffer = kvzalloc(VDPASIM_BLK_CAPACITY << SECTOR_SHIFT,
441441
GFP_KERNEL);
442442
if (!blk->buffer) {
443443
ret = -ENOMEM;
@@ -495,7 +495,7 @@ static int __init vdpasim_blk_init(void)
495495
goto parent_err;
496496

497497
if (shared_backend) {
498-
shared_buffer = kvmalloc(VDPASIM_BLK_CAPACITY << SECTOR_SHIFT,
498+
shared_buffer = kvzalloc(VDPASIM_BLK_CAPACITY << SECTOR_SHIFT,
499499
GFP_KERNEL);
500500
if (!shared_buffer) {
501501
ret = -ENOMEM;

0 commit comments

Comments
 (0)