Skip to content

Commit 0dfe9bf

Browse files
Shawn Guobebarino
authored andcommitted
clk: qcom: apcs-msm8916: Flag a53mux instead of a53pll as critical
The clock source for MSM8916 cpu cores is like below. |\ a53pll --------| \ a53mux +------+ | |------------| cpus | gpll0_vote --------| / +------+ |/ So a53mux rather than a53pll is actually the parent clock of cpu cores. It makes more sense to flag a53mux as critical instead, so that when either a53pll or gpll0_vote is used by cpu cores, the clock will be kept enabled while the other can be disabled. Signed-off-by: Shawn Guo <shawn.guo@linaro.org> Link: https://lore.kernel.org/r/20210704024032.11559-2-shawn.guo@linaro.org Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 945cb3a commit 0dfe9bf

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/clk/qcom/a53-pll.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ static int qcom_a53pll_probe(struct platform_device *pdev)
7070
init.parent_names = (const char *[]){ "xo" };
7171
init.num_parents = 1;
7272
init.ops = &clk_pll_sr2_ops;
73-
init.flags = CLK_IS_CRITICAL;
7473
pll->clkr.hw.init = &init;
7574

7675
ret = devm_clk_register_regmap(dev, &pll->clkr);

drivers/clk/qcom/apcs-msm8916.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ static int qcom_apcs_msm8916_clk_probe(struct platform_device *pdev)
6565
init.parent_data = pdata;
6666
init.num_parents = ARRAY_SIZE(pdata);
6767
init.ops = &clk_regmap_mux_div_ops;
68-
init.flags = CLK_SET_RATE_PARENT;
68+
init.flags = CLK_IS_CRITICAL | CLK_SET_RATE_PARENT;
6969

7070
a53cc->clkr.hw.init = &init;
7171
a53cc->clkr.regmap = regmap;

0 commit comments

Comments
 (0)