Skip to content

Commit 0e4ec14

Browse files
matttbekuba-moo
authored andcommitted
selftests: mptcp: join: userspace: longer timeout
In rare cases, when the test environment is very slow, some userspace tests can fail because some expected events have not been seen. Because the tests are expecting a long on-going connection, and they are not waiting for the end of the transfer, it is fine to have a longer timeout, and even go over the default one. This connection will be killed at the end, after the verifications: increasing the timeout doesn't change anything, apart from avoiding it to end before the end of the verifications. To play it safe, all userspace tests not waiting for the end of the transfer are now having a longer timeout: 2 minutes. The Fixes commit was making the connection longer, but still, the default timeout would have stopped it after 1 minute, which might not be enough in very slow environments. Fixes: 2904930 ("selftests: mptcp: join: userspace: longer transfer") Cc: stable@vger.kernel.org Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Reviewed-by: Geliang Tang <geliang@kernel.org> Link: https://patch.msgid.link/20251118-net-mptcp-misc-fixes-6-18-rc6-v1-9-806d3781c95f@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent fb13c6b commit 0e4ec14

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

tools/testing/selftests/net/mptcp/mptcp_join.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3804,7 +3804,7 @@ userspace_tests()
38043804
continue_if mptcp_lib_has_file '/proc/sys/net/mptcp/pm_type'; then
38053805
set_userspace_pm $ns1
38063806
pm_nl_set_limits $ns2 2 2
3807-
{ test_linkfail=128 speed=5 \
3807+
{ timeout_test=120 test_linkfail=128 speed=5 \
38083808
run_tests $ns1 $ns2 10.0.1.1 & } 2>/dev/null
38093809
local tests_pid=$!
38103810
wait_mpj $ns1
@@ -3837,7 +3837,7 @@ userspace_tests()
38373837
continue_if mptcp_lib_has_file '/proc/sys/net/mptcp/pm_type'; then
38383838
set_userspace_pm $ns2
38393839
pm_nl_set_limits $ns1 0 1
3840-
{ test_linkfail=128 speed=5 \
3840+
{ timeout_test=120 test_linkfail=128 speed=5 \
38413841
run_tests $ns1 $ns2 10.0.1.1 & } 2>/dev/null
38423842
local tests_pid=$!
38433843
wait_mpj $ns2
@@ -3865,7 +3865,7 @@ userspace_tests()
38653865
continue_if mptcp_lib_has_file '/proc/sys/net/mptcp/pm_type'; then
38663866
set_userspace_pm $ns2
38673867
pm_nl_set_limits $ns1 0 1
3868-
{ test_linkfail=128 speed=5 \
3868+
{ timeout_test=120 test_linkfail=128 speed=5 \
38693869
run_tests $ns1 $ns2 10.0.1.1 & } 2>/dev/null
38703870
local tests_pid=$!
38713871
wait_mpj $ns2
@@ -3886,7 +3886,7 @@ userspace_tests()
38863886
continue_if mptcp_lib_has_file '/proc/sys/net/mptcp/pm_type'; then
38873887
set_userspace_pm $ns2
38883888
pm_nl_set_limits $ns1 0 1
3889-
{ test_linkfail=128 speed=5 \
3889+
{ timeout_test=120 test_linkfail=128 speed=5 \
38903890
run_tests $ns1 $ns2 10.0.1.1 & } 2>/dev/null
38913891
local tests_pid=$!
38923892
wait_mpj $ns2
@@ -3910,7 +3910,7 @@ userspace_tests()
39103910
continue_if mptcp_lib_has_file '/proc/sys/net/mptcp/pm_type'; then
39113911
set_userspace_pm $ns1
39123912
pm_nl_set_limits $ns2 1 1
3913-
{ test_linkfail=128 speed=5 \
3913+
{ timeout_test=120 test_linkfail=128 speed=5 \
39143914
run_tests $ns1 $ns2 10.0.1.1 & } 2>/dev/null
39153915
local tests_pid=$!
39163916
wait_mpj $ns1

0 commit comments

Comments
 (0)