Skip to content

Commit 0e53aa3

Browse files
bijudasvinodkoul
authored andcommitted
dmaengine: sh: rz-dmac: Fix lockdep assert warning
Fix the below lockdep assert warning by holding vc.lock for vchan_get_all_descriptors(). WARNING: virt-dma.h:188 rz_dmac_terminate_all pc : rz_dmac_terminate_all Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Link: https://lore.kernel.org/r/20240625170119.173595-1-biju.das.jz@bp.renesas.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 73115d8 commit 0e53aa3

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/dma/sh/rz-dmac.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -540,8 +540,8 @@ static int rz_dmac_terminate_all(struct dma_chan *chan)
540540
spin_lock_irqsave(&channel->vc.lock, flags);
541541
list_splice_tail_init(&channel->ld_active, &channel->ld_free);
542542
list_splice_tail_init(&channel->ld_queue, &channel->ld_free);
543-
spin_unlock_irqrestore(&channel->vc.lock, flags);
544543
vchan_get_all_descriptors(&channel->vc, &head);
544+
spin_unlock_irqrestore(&channel->vc.lock, flags);
545545
vchan_dma_desc_free_list(&channel->vc, &head);
546546

547547
return 0;

0 commit comments

Comments
 (0)