Skip to content

Commit 0ec8935

Browse files
Uwe Kleine-Königdavem330
authored andcommitted
net: mdio: mux-gpio: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() is renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 4c86f22 commit 0ec8935

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

drivers/net/mdio/mdio-mux-gpio.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,10 @@ static int mdio_mux_gpio_probe(struct platform_device *pdev)
6262
return 0;
6363
}
6464

65-
static int mdio_mux_gpio_remove(struct platform_device *pdev)
65+
static void mdio_mux_gpio_remove(struct platform_device *pdev)
6666
{
6767
struct mdio_mux_gpio_state *s = dev_get_platdata(&pdev->dev);
6868
mdio_mux_uninit(s->mux_handle);
69-
return 0;
7069
}
7170

7271
static const struct of_device_id mdio_mux_gpio_match[] = {
@@ -87,7 +86,7 @@ static struct platform_driver mdio_mux_gpio_driver = {
8786
.of_match_table = mdio_mux_gpio_match,
8887
},
8988
.probe = mdio_mux_gpio_probe,
90-
.remove = mdio_mux_gpio_remove,
89+
.remove_new = mdio_mux_gpio_remove,
9190
};
9291

9392
module_platform_driver(mdio_mux_gpio_driver);

0 commit comments

Comments
 (0)