drm/sun4i: Fix DE2 YVU handling

jernejsk · mripard · commit 0ee9f600e69d · 2020-09-04T11:05:58.000+02:00
Function sun8i_vi_layer_get_csc_mode() is supposed to return CSC mode but due to inproper return type (bool instead of u32) it returns just 0 or 1. Colors are wrong for YVU formats because of that. Fixes: daab3d0 ("drm/sun4i: de2: csc_mode in de2 format struct is mostly redundant") Reported-by: Roman Stratiienko <r.stratiienko@gmail.com> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> Tested-by: Roman Stratiienko <r.stratiienko@gmail.com> Signed-off-by: Maxime Ripard <maxime@cerno.tech> Link: https://patchwork.freedesktop.org/patch/msgid/20200901220305.6809-1-jernej.skrabec@siol.net
diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c
@@ -211,7 +211,7 @@ static int sun8i_vi_layer_update_coord(struct sun8i_mixer *mixer, int channel,
 	return 0;
 }
 
-static bool sun8i_vi_layer_get_csc_mode(const struct drm_format_info *format)
+static u32 sun8i_vi_layer_get_csc_mode(const struct drm_format_info *format)
 {
 	if (!format->is_yuv)
 		return SUN8I_CSC_MODE_OFF;

Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,7 @@ static int sun8i_vi_layer_update_coord(struct sun8i_mixer *mixer, int channel,`
`211`	`211`	`return 0;`
`212`	`212`	`}`
`213`	`213`
`214`		`-static bool sun8i_vi_layer_get_csc_mode(const struct drm_format_info *format)`
	`214`	`+static u32 sun8i_vi_layer_get_csc_mode(const struct drm_format_info *format)`
`215`	`215`	`{`
`216`	`216`	`if (!format->is_yuv)`
`217`	`217`	`return SUN8I_CSC_MODE_OFF;`