Skip to content

Commit 0eee0fd

Browse files
Dwyane-Yankuba-moo
authored andcommitted
selftests: mptcp: add a check for 'add_addr_accepted'
The previous patch fixed an issue with the 'add_addr_accepted' counter. This was not spot by the test suite. Check this counter and 'add_addr_signal' in MPTCP Join 'delete re-add signal' test. This should help spotting similar regressions later on. These counters are crucial for ensuring the MPTCP path manager correctly handles the subflow creation via 'ADD_ADDR'. Signed-off-by: Gang Yan <yangang@kylinos.cn> Reviewed-by: Geliang Tang <geliang@kernel.org> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Link: https://patch.msgid.link/20251118-net-mptcp-misc-fixes-6-18-rc6-v1-11-806d3781c95f@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 92e239e commit 0eee0fd

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

tools/testing/selftests/net/mptcp/mptcp_join.sh

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4055,38 +4055,45 @@ endpoint_tests()
40554055
$ns1 10.0.2.1 id 1 flags signal
40564056
chk_subflow_nr "before delete" 2
40574057
chk_mptcp_info subflows 1 subflows 1
4058+
chk_mptcp_info add_addr_signal 2 add_addr_accepted 1
40584059

40594060
pm_nl_del_endpoint $ns1 1 10.0.2.1
40604061
pm_nl_del_endpoint $ns1 2 224.0.0.1
40614062
sleep 0.5
40624063
chk_subflow_nr "after delete" 1
40634064
chk_mptcp_info subflows 0 subflows 0
4065+
chk_mptcp_info add_addr_signal 0 add_addr_accepted 0
40644066

40654067
pm_nl_add_endpoint $ns1 10.0.2.1 id 1 flags signal
40664068
pm_nl_add_endpoint $ns1 10.0.3.1 id 2 flags signal
40674069
wait_mpj $ns2
40684070
chk_subflow_nr "after re-add" 3
40694071
chk_mptcp_info subflows 2 subflows 2
4072+
chk_mptcp_info add_addr_signal 2 add_addr_accepted 2
40704073

40714074
pm_nl_del_endpoint $ns1 42 10.0.1.1
40724075
sleep 0.5
40734076
chk_subflow_nr "after delete ID 0" 2
40744077
chk_mptcp_info subflows 2 subflows 2
4078+
chk_mptcp_info add_addr_signal 2 add_addr_accepted 2
40754079

40764080
pm_nl_add_endpoint $ns1 10.0.1.1 id 99 flags signal
40774081
wait_mpj $ns2
40784082
chk_subflow_nr "after re-add ID 0" 3
40794083
chk_mptcp_info subflows 3 subflows 3
4084+
chk_mptcp_info add_addr_signal 3 add_addr_accepted 2
40804085

40814086
pm_nl_del_endpoint $ns1 99 10.0.1.1
40824087
sleep 0.5
40834088
chk_subflow_nr "after re-delete ID 0" 2
40844089
chk_mptcp_info subflows 2 subflows 2
4090+
chk_mptcp_info add_addr_signal 2 add_addr_accepted 2
40854091

40864092
pm_nl_add_endpoint $ns1 10.0.1.1 id 88 flags signal
40874093
wait_mpj $ns2
40884094
chk_subflow_nr "after re-re-add ID 0" 3
40894095
chk_mptcp_info subflows 3 subflows 3
4096+
chk_mptcp_info add_addr_signal 3 add_addr_accepted 2
40904097
mptcp_lib_kill_group_wait $tests_pid
40914098

40924099
kill_events_pids

0 commit comments

Comments
 (0)