drm/ssd130x: Call drm_atomic_helper_shutdown() at remove time

dianders · dianders · commit 10c8204c8b17 · 2023-09-21T10:50:03.000-07:00
Based on grepping through the source code, this driver appears to be missing a call to drm_atomic_helper_shutdown() at remove time. Let's add it. The fact that we should call drm_atomic_helper_shutdown() in the case of OS driver remove comes straight out of the kernel doc "driver instance overview" in drm_drv.c. Suggested-by: Maxime Ripard <mripard@kernel.org> Acked-by: Maxime Ripard <mripard@kernel.org> Signed-off-by: Douglas Anderson <dianders@chromium.org> Link: https://patchwork.freedesktop.org/patch/msgid/20230901163944.RFT.4.I4752a39ad9f8fd08b32c2b78a8a3e40491bfb5eb@changeid
diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c
@@ -1245,6 +1245,7 @@ EXPORT_SYMBOL_GPL(ssd130x_probe);
 void ssd130x_remove(struct ssd130x_device *ssd130x)
 {
 	drm_dev_unplug(&ssd130x->drm);
+	drm_atomic_helper_shutdown(&ssd130x->drm);
 }
 EXPORT_SYMBOL_GPL(ssd130x_remove);
 

Original file line number	Diff line number	Diff line change
`@@ -1245,6 +1245,7 @@ EXPORT_SYMBOL_GPL(ssd130x_probe);`
`1245`	`1245`	`void ssd130x_remove(struct ssd130x_device *ssd130x)`
`1246`	`1246`	`{`
`1247`	`1247`	`drm_dev_unplug(&ssd130x->drm);`
	`1248`	`+ drm_atomic_helper_shutdown(&ssd130x->drm);`
`1248`	`1249`	`}`
`1249`	`1250`	`EXPORT_SYMBOL_GPL(ssd130x_remove);`
`1250`	`1251`