Skip to content

Commit 10f19fd

Browse files
Uwe Kleine-Königmathieupoirier
authored andcommitted
remoteproc: keystone: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230504194453.1150368-5-u.kleine-koenig@pengutronix.de Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
1 parent 94ea6ed commit 10f19fd

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/remoteproc/keystone_remoteproc.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@ static int keystone_rproc_probe(struct platform_device *pdev)
476476
return ret;
477477
}
478478

479-
static int keystone_rproc_remove(struct platform_device *pdev)
479+
static void keystone_rproc_remove(struct platform_device *pdev)
480480
{
481481
struct keystone_rproc *ksproc = platform_get_drvdata(pdev);
482482

@@ -486,8 +486,6 @@ static int keystone_rproc_remove(struct platform_device *pdev)
486486
pm_runtime_disable(&pdev->dev);
487487
rproc_free(ksproc->rproc);
488488
of_reserved_mem_device_release(&pdev->dev);
489-
490-
return 0;
491489
}
492490

493491
static const struct of_device_id keystone_rproc_of_match[] = {
@@ -501,7 +499,7 @@ MODULE_DEVICE_TABLE(of, keystone_rproc_of_match);
501499

502500
static struct platform_driver keystone_rproc_driver = {
503501
.probe = keystone_rproc_probe,
504-
.remove = keystone_rproc_remove,
502+
.remove_new = keystone_rproc_remove,
505503
.driver = {
506504
.name = "keystone-rproc",
507505
.of_match_table = keystone_rproc_of_match,

0 commit comments

Comments
 (0)