Skip to content

Commit 114ca29

Browse files
Marek Vasutbjorn-helgaas
authored andcommitted
PCI: altera-msi: Silence 'set affinity failed' warning
Use MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity() unset and allows migrate_one_irq() to exit right away, without warnings like this: IRQ...: set affinity failed(-22) Remove the .irq_set_affinity() implementation that is no longer needed. Link: https://lore.kernel.org/r/20240723132958.41320-4-marek.vasut+renesas@mailbox.org Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> [bhelgaas: commit log] Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Acked-by: Thomas Gleixner <tglx@linutronix.de>
1 parent 4dff9c3 commit 114ca29

1 file changed

Lines changed: 2 additions & 9 deletions

File tree

drivers/pci/controller/pcie-altera-msi.c

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ static struct irq_chip altera_msi_irq_chip = {
8181
};
8282

8383
static struct msi_domain_info altera_msi_domain_info = {
84-
.flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
85-
MSI_FLAG_PCI_MSIX),
84+
.flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
85+
MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX,
8686
.chip = &altera_msi_irq_chip,
8787
};
8888

@@ -99,16 +99,9 @@ static void altera_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
9999
(int)data->hwirq, msg->address_hi, msg->address_lo);
100100
}
101101

102-
static int altera_msi_set_affinity(struct irq_data *irq_data,
103-
const struct cpumask *mask, bool force)
104-
{
105-
return -EINVAL;
106-
}
107-
108102
static struct irq_chip altera_msi_bottom_irq_chip = {
109103
.name = "Altera MSI",
110104
.irq_compose_msi_msg = altera_compose_msi_msg,
111-
.irq_set_affinity = altera_msi_set_affinity,
112105
};
113106

114107
static int altera_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,

0 commit comments

Comments
 (0)