Skip to content

Commit 1150ea9

Browse files
davidhildenbrandakpm00
authored andcommitted
selftests/ksm: ksm_functional_tests: add prctl unmerge test
Let's test whether setting PR_SET_MEMORY_MERGE to 0 after setting it to 1 will unmerge pages, similar to how setting MADV_UNMERGEABLE after setting MADV_MERGEABLE would. Link: https://lkml.kernel.org/r/20230422205420.30372-3-david@redhat.com Signed-off-by: David Hildenbrand <david@redhat.com> Acked-by: Stefan Roesch <shr@devkernel.io> Cc: Christian Borntraeger <borntraeger@linux.ibm.com> Cc: Claudio Imbrenda <imbrenda@linux.ibm.com> Cc: Heiko Carstens <hca@linux.ibm.com> Cc: Janosch Frank <frankja@linux.ibm.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Michal Hocko <mhocko@suse.com> Cc: Rik van Riel <riel@surriel.com> Cc: Shuah Khan <shuah@kernel.org> Cc: Sven Schnelle <svens@linux.ibm.com> Cc: Vasily Gorbik <gor@linux.ibm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 24139c0 commit 1150ea9

1 file changed

Lines changed: 40 additions & 6 deletions

File tree

tools/testing/selftests/mm/ksm_functional_tests.c

Lines changed: 40 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,10 @@ static int ksm_merge(void)
9191
return 0;
9292
}
9393

94-
static char *mmap_and_merge_range(char val, unsigned long size)
94+
static char *mmap_and_merge_range(char val, unsigned long size, bool use_prctl)
9595
{
9696
char *map;
97+
int ret;
9798

9899
map = mmap(NULL, size, PROT_READ|PROT_WRITE,
99100
MAP_PRIVATE|MAP_ANON, -1, 0);
@@ -110,7 +111,17 @@ static char *mmap_and_merge_range(char val, unsigned long size)
110111

111112
/* Make sure each page contains the same values to merge them. */
112113
memset(map, val, size);
113-
if (madvise(map, size, MADV_MERGEABLE)) {
114+
115+
if (use_prctl) {
116+
ret = prctl(PR_SET_MEMORY_MERGE, 1, 0, 0, 0);
117+
if (ret < 0 && errno == EINVAL) {
118+
ksft_test_result_skip("PR_SET_MEMORY_MERGE not supported\n");
119+
goto unmap;
120+
} else if (ret) {
121+
ksft_test_result_fail("PR_SET_MEMORY_MERGE=1 failed\n");
122+
goto unmap;
123+
}
124+
} else if (madvise(map, size, MADV_MERGEABLE)) {
114125
ksft_test_result_fail("MADV_MERGEABLE failed\n");
115126
goto unmap;
116127
}
@@ -133,7 +144,7 @@ static void test_unmerge(void)
133144

134145
ksft_print_msg("[RUN] %s\n", __func__);
135146

136-
map = mmap_and_merge_range(0xcf, size);
147+
map = mmap_and_merge_range(0xcf, size, false);
137148
if (map == MAP_FAILED)
138149
return;
139150

@@ -155,7 +166,7 @@ static void test_unmerge_discarded(void)
155166

156167
ksft_print_msg("[RUN] %s\n", __func__);
157168

158-
map = mmap_and_merge_range(0xcf, size);
169+
map = mmap_and_merge_range(0xcf, size, false);
159170
if (map == MAP_FAILED)
160171
return;
161172

@@ -187,7 +198,7 @@ static void test_unmerge_uffd_wp(void)
187198

188199
ksft_print_msg("[RUN] %s\n", __func__);
189200

190-
map = mmap_and_merge_range(0xcf, size);
201+
map = mmap_and_merge_range(0xcf, size, false);
191202
if (map == MAP_FAILED)
192203
return;
193204

@@ -323,9 +334,31 @@ static void test_prctl_fork(void)
323334
ksft_test_result_pass("PR_SET_MEMORY_MERGE value is inherited\n");
324335
}
325336

337+
static void test_prctl_unmerge(void)
338+
{
339+
const unsigned int size = 2 * MiB;
340+
char *map;
341+
342+
ksft_print_msg("[RUN] %s\n", __func__);
343+
344+
map = mmap_and_merge_range(0xcf, size, true);
345+
if (map == MAP_FAILED)
346+
return;
347+
348+
if (prctl(PR_SET_MEMORY_MERGE, 0, 0, 0, 0)) {
349+
ksft_test_result_fail("PR_SET_MEMORY_MERGE=0 failed\n");
350+
goto unmap;
351+
}
352+
353+
ksft_test_result(!range_maps_duplicates(map, size),
354+
"Pages were unmerged\n");
355+
unmap:
356+
munmap(map, size);
357+
}
358+
326359
int main(int argc, char **argv)
327360
{
328-
unsigned int tests = 4;
361+
unsigned int tests = 5;
329362
int err;
330363

331364
#ifdef __NR_userfaultfd
@@ -355,6 +388,7 @@ int main(int argc, char **argv)
355388

356389
test_prctl();
357390
test_prctl_fork();
391+
test_prctl_unmerge();
358392

359393
err = ksft_get_fail_cnt();
360394
if (err)

0 commit comments

Comments
 (0)