Skip to content

Commit 11d8620

Browse files
fbqliuw
authored andcommitted
hv_netvsc: Use HV_HYP_PAGE_SIZE for Hyper-V communication
When communicating with Hyper-V, HV_HYP_PAGE_SIZE should be used since that's the page size used by Hyper-V and Hyper-V expects all page-related data using the unit of HY_HYP_PAGE_SIZE, for example, the "pfn" in hv_page_buffer is actually the HV_HYP_PAGE (i.e. the Hyper-V page) number. In order to support guest whose page size is not 4k, we need to make hv_netvsc always use HV_HYP_PAGE_SIZE for Hyper-V communication. Signed-off-by: Boqun Feng <boqun.feng@gmail.com> Reviewed-by: Michael Kelley <mikelley@microsoft.com> Link: https://lore.kernel.org/r/20200916034817.30282-8-boqun.feng@gmail.com Signed-off-by: Wei Liu <wei.liu@kernel.org>
1 parent 106dee0 commit 11d8620

3 files changed

Lines changed: 30 additions & 31 deletions

File tree

drivers/net/hyperv/netvsc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -794,7 +794,7 @@ static void netvsc_copy_to_send_buf(struct netvsc_device *net_device,
794794
}
795795

796796
for (i = 0; i < page_count; i++) {
797-
char *src = phys_to_virt(pb[i].pfn << PAGE_SHIFT);
797+
char *src = phys_to_virt(pb[i].pfn << HV_HYP_PAGE_SHIFT);
798798
u32 offset = pb[i].offset;
799799
u32 len = pb[i].len;
800800

drivers/net/hyperv/netvsc_drv.c

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -373,32 +373,29 @@ static u16 netvsc_select_queue(struct net_device *ndev, struct sk_buff *skb,
373373
return txq;
374374
}
375375

376-
static u32 fill_pg_buf(struct page *page, u32 offset, u32 len,
376+
static u32 fill_pg_buf(unsigned long hvpfn, u32 offset, u32 len,
377377
struct hv_page_buffer *pb)
378378
{
379379
int j = 0;
380380

381-
/* Deal with compound pages by ignoring unused part
382-
* of the page.
383-
*/
384-
page += (offset >> PAGE_SHIFT);
385-
offset &= ~PAGE_MASK;
381+
hvpfn += offset >> HV_HYP_PAGE_SHIFT;
382+
offset = offset & ~HV_HYP_PAGE_MASK;
386383

387384
while (len > 0) {
388385
unsigned long bytes;
389386

390-
bytes = PAGE_SIZE - offset;
387+
bytes = HV_HYP_PAGE_SIZE - offset;
391388
if (bytes > len)
392389
bytes = len;
393-
pb[j].pfn = page_to_pfn(page);
390+
pb[j].pfn = hvpfn;
394391
pb[j].offset = offset;
395392
pb[j].len = bytes;
396393

397394
offset += bytes;
398395
len -= bytes;
399396

400-
if (offset == PAGE_SIZE && len) {
401-
page++;
397+
if (offset == HV_HYP_PAGE_SIZE && len) {
398+
hvpfn++;
402399
offset = 0;
403400
j++;
404401
}
@@ -421,23 +418,26 @@ static u32 init_page_array(void *hdr, u32 len, struct sk_buff *skb,
421418
* 2. skb linear data
422419
* 3. skb fragment data
423420
*/
424-
slots_used += fill_pg_buf(virt_to_page(hdr),
425-
offset_in_page(hdr),
426-
len, &pb[slots_used]);
421+
slots_used += fill_pg_buf(virt_to_hvpfn(hdr),
422+
offset_in_hvpage(hdr),
423+
len,
424+
&pb[slots_used]);
427425

428426
packet->rmsg_size = len;
429427
packet->rmsg_pgcnt = slots_used;
430428

431-
slots_used += fill_pg_buf(virt_to_page(data),
432-
offset_in_page(data),
433-
skb_headlen(skb), &pb[slots_used]);
429+
slots_used += fill_pg_buf(virt_to_hvpfn(data),
430+
offset_in_hvpage(data),
431+
skb_headlen(skb),
432+
&pb[slots_used]);
434433

435434
for (i = 0; i < frags; i++) {
436435
skb_frag_t *frag = skb_shinfo(skb)->frags + i;
437436

438-
slots_used += fill_pg_buf(skb_frag_page(frag),
439-
skb_frag_off(frag),
440-
skb_frag_size(frag), &pb[slots_used]);
437+
slots_used += fill_pg_buf(page_to_hvpfn(skb_frag_page(frag)),
438+
skb_frag_off(frag),
439+
skb_frag_size(frag),
440+
&pb[slots_used]);
441441
}
442442
return slots_used;
443443
}
@@ -453,21 +453,21 @@ static int count_skb_frag_slots(struct sk_buff *skb)
453453
unsigned long offset = skb_frag_off(frag);
454454

455455
/* Skip unused frames from start of page */
456-
offset &= ~PAGE_MASK;
457-
pages += PFN_UP(offset + size);
456+
offset &= ~HV_HYP_PAGE_MASK;
457+
pages += HVPFN_UP(offset + size);
458458
}
459459
return pages;
460460
}
461461

462462
static int netvsc_get_slots(struct sk_buff *skb)
463463
{
464464
char *data = skb->data;
465-
unsigned int offset = offset_in_page(data);
465+
unsigned int offset = offset_in_hvpage(data);
466466
unsigned int len = skb_headlen(skb);
467467
int slots;
468468
int frag_slots;
469469

470-
slots = DIV_ROUND_UP(offset + len, PAGE_SIZE);
470+
slots = DIV_ROUND_UP(offset + len, HV_HYP_PAGE_SIZE);
471471
frag_slots = count_skb_frag_slots(skb);
472472
return slots + frag_slots;
473473
}

drivers/net/hyperv/rndis_filter.c

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
static void rndis_set_multicast(struct work_struct *w);
2727

28-
#define RNDIS_EXT_LEN PAGE_SIZE
28+
#define RNDIS_EXT_LEN HV_HYP_PAGE_SIZE
2929
struct rndis_request {
3030
struct list_head list_ent;
3131
struct completion wait_event;
@@ -215,18 +215,17 @@ static int rndis_filter_send_request(struct rndis_device *dev,
215215
packet->page_buf_cnt = 1;
216216

217217
pb[0].pfn = virt_to_phys(&req->request_msg) >>
218-
PAGE_SHIFT;
218+
HV_HYP_PAGE_SHIFT;
219219
pb[0].len = req->request_msg.msg_len;
220-
pb[0].offset =
221-
(unsigned long)&req->request_msg & (PAGE_SIZE - 1);
220+
pb[0].offset = offset_in_hvpage(&req->request_msg);
222221

223222
/* Add one page_buf when request_msg crossing page boundary */
224-
if (pb[0].offset + pb[0].len > PAGE_SIZE) {
223+
if (pb[0].offset + pb[0].len > HV_HYP_PAGE_SIZE) {
225224
packet->page_buf_cnt++;
226-
pb[0].len = PAGE_SIZE -
225+
pb[0].len = HV_HYP_PAGE_SIZE -
227226
pb[0].offset;
228227
pb[1].pfn = virt_to_phys((void *)&req->request_msg
229-
+ pb[0].len) >> PAGE_SHIFT;
228+
+ pb[0].len) >> HV_HYP_PAGE_SHIFT;
230229
pb[1].offset = 0;
231230
pb[1].len = req->request_msg.msg_len -
232231
pb[0].len;

0 commit comments

Comments
 (0)