Skip to content

Commit 11e298f

Browse files
Shyam Sundar S Kjwrdegoede
authored andcommitted
platform/x86/amd/pmf: Fix TEE enact command failure after suspend and resume
TEE enact command failures are seen after each suspend/resume cycle; fix this by cancelling the policy builder workqueue before going into suspend and reschedule the workqueue after resume. [ 629.516792] ccp 0000:c2:00.2: tee: command 0x5 timed out, disabling PSP [ 629.516835] amd-pmf AMDI0102:00: TEE enact cmd failed. err: ffff000e, ret:0 [ 630.550464] amd-pmf AMDI0102:00: AMD_PMF_REGISTER_RESPONSE:1 [ 630.550511] amd-pmf AMDI0102:00: AMD_PMF_REGISTER_ARGUMENT:7 [ 630.550548] amd-pmf AMDI0102:00: AMD_PMF_REGISTER_MESSAGE:16 Fixes: ae82cef ("platform/x86/amd/pmf: Add support for PMF-TA interaction") Co-developed-by: Patil Rajesh Reddy <Patil.Reddy@amd.com> Signed-off-by: Patil Rajesh Reddy <Patil.Reddy@amd.com> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> Link: https://lore.kernel.org/r/20240216064112.962582-2-Shyam-sundar.S-k@amd.com Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
1 parent 3da0139 commit 11e298f

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

  • drivers/platform/x86/amd/pmf

drivers/platform/x86/amd/pmf/core.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -296,6 +296,9 @@ static int amd_pmf_suspend_handler(struct device *dev)
296296
{
297297
struct amd_pmf_dev *pdev = dev_get_drvdata(dev);
298298

299+
if (pdev->smart_pc_enabled)
300+
cancel_delayed_work_sync(&pdev->pb_work);
301+
299302
kfree(pdev->buf);
300303

301304
return 0;
@@ -312,6 +315,9 @@ static int amd_pmf_resume_handler(struct device *dev)
312315
return ret;
313316
}
314317

318+
if (pdev->smart_pc_enabled)
319+
schedule_delayed_work(&pdev->pb_work, msecs_to_jiffies(2000));
320+
315321
return 0;
316322
}
317323

0 commit comments

Comments
 (0)