Skip to content

Commit 1233751

Browse files
Christoph Hellwigaxboe
authored andcommitted
usb-storage: fix queue freeze vs limits lock order
Match the locking order used by the core block code by only freezing the queue after taking the limits lock using the queue_limits_commit_update_frozen helper. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Ming Lei <ming.lei@redhat.com> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> Reviewed-by: Nilay Shroff <nilay@linux.ibm.com> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> Link: https://lore.kernel.org/r/20250110054726.1499538-10-hch@lst.de Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent f3dec61 commit 1233751

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

drivers/usb/storage/scsiglue.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -592,12 +592,9 @@ static ssize_t max_sectors_store(struct device *dev, struct device_attribute *at
592592
if (sscanf(buf, "%hu", &ms) <= 0)
593593
return -EINVAL;
594594

595-
blk_mq_freeze_queue(sdev->request_queue);
596595
lim = queue_limits_start_update(sdev->request_queue);
597596
lim.max_hw_sectors = ms;
598-
ret = queue_limits_commit_update(sdev->request_queue, &lim);
599-
blk_mq_unfreeze_queue(sdev->request_queue);
600-
597+
ret = queue_limits_commit_update_frozen(sdev->request_queue, &lim);
601598
if (ret)
602599
return ret;
603600
return count;

0 commit comments

Comments
 (0)