Skip to content

Commit 1296611

Browse files
committed
Merge tag 'intel-pinctrl-v6.20-2' of git://git.kernel.org/pub/scm/linux/kernel/git/pinctrl/intel into devel
intel-pinctrl for v6.20-2 * Remove duplicate error messages when registering pin control * Miscellaneous changes Signed-off-by: Linus Walleij <linusw@kernel.org>
2 parents c0b4a4f + 8e03e6e commit 1296611

5 files changed

Lines changed: 11 additions & 18 deletions

File tree

drivers/pinctrl/intel/pinctrl-baytrail.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1616,7 +1616,7 @@ static int byt_pinctrl_probe(struct platform_device *pdev)
16161616

16171617
vg->pctldev = devm_pinctrl_register(dev, &vg->pctldesc, vg);
16181618
if (IS_ERR(vg->pctldev))
1619-
return dev_err_probe(dev, PTR_ERR(vg->pctldev), "failed to register pinctrl\n");
1619+
return PTR_ERR(vg->pctldev);
16201620

16211621
ret = byt_gpio_probe(vg);
16221622
if (ret)

drivers/pinctrl/intel/pinctrl-cherryview.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1644,7 +1644,7 @@ static int chv_pinctrl_probe(struct platform_device *pdev)
16441644

16451645
pctrl->pctldev = devm_pinctrl_register(dev, &pctrl->pctldesc, pctrl);
16461646
if (IS_ERR(pctrl->pctldev))
1647-
return dev_err_probe(dev, PTR_ERR(pctrl->pctldev), "failed to register pinctrl\n");
1647+
return PTR_ERR(pctrl->pctldev);
16481648

16491649
ret = chv_gpio_probe(pctrl, irq);
16501650
if (ret)

drivers/pinctrl/intel/pinctrl-intel.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1673,7 +1673,7 @@ int intel_pinctrl_probe(struct platform_device *pdev,
16731673

16741674
pctrl->pctldev = devm_pinctrl_register(dev, &pctrl->pctldesc, pctrl);
16751675
if (IS_ERR(pctrl->pctldev))
1676-
return dev_err_probe(dev, PTR_ERR(pctrl->pctldev), "failed to register pinctrl\n");
1676+
return PTR_ERR(pctrl->pctldev);
16771677

16781678
ret = intel_gpio_probe(pctrl, irq);
16791679
if (ret)

drivers/pinctrl/intel/pinctrl-lynxpoint.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -735,7 +735,7 @@ static int lp_gpio_probe(struct platform_device *pdev)
735735

736736
lg->pctldev = devm_pinctrl_register(dev, &lg->pctldesc, lg);
737737
if (IS_ERR(lg->pctldev))
738-
return dev_err_probe(dev, PTR_ERR(lg->pctldev), "failed to register pinctrl\n");
738+
return PTR_ERR(lg->pctldev);
739739

740740
platform_set_drvdata(pdev, lg);
741741

drivers/pinctrl/intel/pinctrl-tangier.c

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -518,15 +518,19 @@ static const struct pinctrl_desc tng_pinctrl_desc = {
518518
.owner = THIS_MODULE,
519519
};
520520

521-
static int tng_pinctrl_probe(struct platform_device *pdev,
522-
const struct tng_pinctrl *data)
521+
int devm_tng_pinctrl_probe(struct platform_device *pdev)
523522
{
524523
struct device *dev = &pdev->dev;
524+
const struct tng_pinctrl *data;
525525
struct tng_family *families;
526526
struct tng_pinctrl *tp;
527527
void __iomem *regs;
528528
unsigned int i;
529529

530+
data = device_get_match_data(dev);
531+
if (!data)
532+
return -ENODATA;
533+
530534
tp = devm_kmemdup(dev, data, sizeof(*data), GFP_KERNEL);
531535
if (!tp)
532536
return -ENOMEM;
@@ -562,21 +566,10 @@ static int tng_pinctrl_probe(struct platform_device *pdev,
562566

563567
tp->pctldev = devm_pinctrl_register(dev, &tp->pctldesc, tp);
564568
if (IS_ERR(tp->pctldev))
565-
return dev_err_probe(dev, PTR_ERR(tp->pctldev), "failed to register pinctrl\n");
569+
return PTR_ERR(tp->pctldev);
566570

567571
return 0;
568572
}
569-
570-
int devm_tng_pinctrl_probe(struct platform_device *pdev)
571-
{
572-
const struct tng_pinctrl *data;
573-
574-
data = device_get_match_data(&pdev->dev);
575-
if (!data)
576-
return -ENODATA;
577-
578-
return tng_pinctrl_probe(pdev, data);
579-
}
580573
EXPORT_SYMBOL_NS_GPL(devm_tng_pinctrl_probe, "PINCTRL_TANGIER");
581574

582575
MODULE_AUTHOR("Andy Shevchenko <andriy.shevchenko@linux.intel.com>");

0 commit comments

Comments
 (0)