ALSA: hda: cs35l56: Remove redundant call to hda_cs_dsp_control_remove()

rfvirgil · tiwai · commit 12d82c7b0a61 · 2024-08-13T13:18:49.000+02:00
The driver doesn't create any ALSA controls for firmware controls, so it shouldn't be calling hda_cs_dsp_control_remove(). commit 34e1b1b ("ALSA: hda: cs35l56: Stop creating ALSA controls for firmware coefficients") removed the call to hda_cs_dsp_add_controls() but didn't remove the call for destroying those controls. Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> Fixes: 34e1b1b ("ALSA: hda: cs35l56: Stop creating ALSA controls for firmware coefficients") Link: https://patch.msgid.link/20240813110750.2814-1-rf@opensource.cirrus.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c
@@ -413,7 +413,7 @@ static void cs35l56_hda_remove_controls(struct cs35l56_hda *cs35l56)
 }
 
 static const struct cs_dsp_client_ops cs35l56_hda_client_ops = {
-	.control_remove = hda_cs_dsp_control_remove,
+	/* cs_dsp requires the client to provide this even if it is empty */
 };
 
 static int cs35l56_hda_request_firmware_file(struct cs35l56_hda *cs35l56,

Original file line number	Diff line number	Diff line change
`@@ -413,7 +413,7 @@ static void cs35l56_hda_remove_controls(struct cs35l56_hda *cs35l56)`
`413`	`413`	`}`
`414`	`414`
`415`	`415`	`static const struct cs_dsp_client_ops cs35l56_hda_client_ops = {`
`416`		`- .control_remove = hda_cs_dsp_control_remove,`
	`416`	`+ /* cs_dsp requires the client to provide this even if it is empty */`
`417`	`417`	`};`
`418`	`418`
`419`	`419`	`static int cs35l56_hda_request_firmware_file(struct cs35l56_hda *cs35l56,`